v.11.1.5 - what is the new code in the Activity Story Stream for?

Good day community :) 

We're feverishly working on Accessibility requirements for our community (coming in to full legislation in Ontario - Canada), and our accessibility checker keeps pinging on this hidden code in the Activity story stream, since there is no hidden aria associated with it. . 

Note, this is for version 11.1.5

It seems the code is stemming from the old way of uploading media - but it's outside the TinyMce functions now (we were under the impression that the TinyMce handled that in the reply field). The code is new in the widget (compared against 10.3.5), and we tested commenting it out, since it doesn't seem to be doing anything, which reduced the errors being reported by the Accessibility checker and doesn't seem to be causing any issues.

We're not sure if there are other areas where this code may be needed, which is why we're asking the community to see if you guys have any insights on this - otherwise we're just going to comment it out... 

Activity story stream -> UI.JS

(function($, global) {

	var Uploader = (function(){

		var defaults = {
			uploadContextId: '',
			uploadUrl: '',
			container: null
		};
		var nameSpace = '_uploader';

		var messaging = $.telligent.evolution.messaging;

		function init(context) {
			if(context.inited)
				return;
			context.inited = true;

			context.uploadContainer = $('<div></div>').hide().appendTo(context.container);
			context.uploadButtonShim = $('<span>upload</span>').appendTo(context.uploadContainer)
				.glowUpload({
					uploadUrl: context.uploadUrl
				})
		}

		return function(options){
			var context = $.extend({
			}, defaults, options || {});

			init(context);

			return {
				upload: function() {
					init(context);

					return $.Deferred(function(d){
						context.uploadButtonShim.off(nameSpace)
						context.uploadButtonShim.on('glowUploadBegun.' + nameSpace, function(e){
						});
						context.uploadButtonShim.on('glowUploadError.' + nameSpace, function(e){
							d.reject();
						})
						context.uploadButtonShim.on('glowUploadFileProgress.' + nameSpace, function(e, details){
							d.notify({
								name: details.name,
								context: context.uploadContextId,
								percent: (details.percent / 100)
							});
						})
						context.uploadButtonShim.on('glowUploadComplete.' + nameSpace, function(e, file){
							d.resolve({
								name: file.name,
								context: context.uploadContextId
							});
						})

						context.uploadContainer.find('input[type="file"]').get(0).click();
					}).promise();
				}
			}
		};

	})();

thanks! 

Parents Reply Children